Page MenuHomePhabricator

Add descriptor reference documentation
ClosedPublic

Authored by deadalnix on Nov 9 2019, 22:59.

Details

Summary
  • Adjust TODO link
  • Replace duplcate reference with reference to reference doc

In addition, add release notes.

Depends on D4421

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14096
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8075
Build 14140: Bitcoin ABC Buildbot (legacy)
Build 14139: arc lint + arc unit

Event Timeline

rebase and fix merge conflict

Fabien requested changes to this revision.Nov 11 2019, 14:54
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/descriptors.md
1 ↗(On Diff #14035)

s/Core/ABC/

3 ↗(On Diff #14035)

v0.20.7

46 ↗(On Diff #14035)

Needs update

57 ↗(On Diff #14035)

Remove

64 ↗(On Diff #14035)

Needs update

66 ↗(On Diff #14035)

Dito

69 ↗(On Diff #14035)

Dito

71 ↗(On Diff #14035)

Dito

72 ↗(On Diff #14035)

Dito

111 ↗(On Diff #14035)

s/Core/ABC/

113 ↗(On Diff #14035)

Needs update

This revision now requires changes to proceed.Nov 11 2019, 14:54
Fabien requested changes to this revision.Nov 12 2019, 14:01
Fabien added inline comments.
doc/descriptors.md
1 ↗(On Diff #14072)

Core => ABC

3 ↗(On Diff #14072)

Dito

This revision now requires changes to proceed.Nov 12 2019, 14:01
doc/descriptors.md
3 ↗(On Diff #14072)

Damn, it's really hard to catch them all (pokemon !).

Rebase and address comments

You finally got the masterball !

This revision is now accepted and ready to land.Nov 12 2019, 14:52