Differential D4454

Fix PSBT error test vectors
ClosedPublic
Actions

Authored by deadalnix on Nov 17 2019, 00:23.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe8f1ceb01f0c: Fix PSBT error test vectors
rABCe8f1ceb01f0c: Fix PSBT error test vectors

Summary

Two of them did fail for various segwit related reasons.

Test Plan

I compiled bitcoin core and ran the test vector through core. Noted the error messages. Then ran the test vector through ABC and figured out the one that failed due to segwit rather than due to what they are supposed to test for. I then updated these test vector accordingly.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

psbterrorfix

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

deadalnix created this revision.Nov 17 2019, 00:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2019, 00:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8135: Diff 14161.Nov 17 2019, 00:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added a child revision: D4456: Check that PSBT keys are the correct length.Nov 17 2019, 17:33

Fabien accepted this revision.Nov 18 2019, 08:44

This revision is now accepted and ready to land.Nov 18 2019, 08:44

Closed by commit rABCe8f1ceb01f0c: Fix PSBT error test vectors (authored by deadalnix). · Explain WhyNov 18 2019, 13:19

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe8f1ceb01f0c: Fix PSBT error test vectors.

deadalnix added a commit: rSTAGINGe8f1ceb01f0c: Fix PSBT error test vectors.Apr 7 2020, 21:42

Revision Contents
Changeset List

Path

Size

test/

functional/

data/

4 lines

Diff 14161

test/functional/data/rpc_psbt.json

Loading...