Page MenuHomePhabricator
Differential D4460

Add Windows shutdown handler
ClosedPublic
Actions

Authored by Fabien on Nov 18 2019, 16:50.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING36179f426c82: Add Windows shutdown handler
rABC36179f426c82: Add Windows shutdown handler
Summary

Exit properly when clicked the red X of Windows Console.

Backport of core PR13131:
https://github.com/bitcoin/bitcoin/pull/13131/files

Test Plan
make check

Cross build for windows.
Run bitcoind.exe in a console and exit with the "red X" (or hit
CTRL+C) button of the console. The software should terminate
gracefully (previously it would abort on an assertion failed in
scheduler destructor).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13131
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8145
Build 14323: Default Diff Build & Tests
Build 14322: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 18 2019, 16:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2019, 16:50
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 18 2019, 16:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 18 2019, 16:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 18 2019, 17:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8145: Diff 14180.Nov 18 2019, 17:02
jasonbcox accepted this revision.Nov 18 2019, 17:45
This revision is now accepted and ready to land.Nov 18 2019, 17:45
teamcity added a comment.Nov 18 2019, 20:30

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Nov 18 2019, 20:43

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABC36179f426c82: Add Windows shutdown handler (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyNov 19 2019, 09:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC36179f426c82: Add Windows shutdown handler.
Fabien added a commit: rSTAGING36179f426c82: Add Windows shutdown handler.Apr 7 2020, 21:42

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 14180

View Options

src/init.cpp

Loading...