Paths

Table of Contentst

Differential D4465

init by extracting shutdown.h
ClosedPublic
Actions

Authored by Fabien on Nov 19 2019, 11:26.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING25f5e271799d: Break circular dependency: init -> * -> init by extracting shutdown.h
rABC25f5e271799d: Break circular dependency: init -> * -> init by extracting shutdown.h

Summary

Most includers just wanted to react to pending shutdown.

This isolates access to `fRequestShutdown` and limits access to the
shutdown
api functions, including the new `AbortShutdown` for setting it to
`false`.

Partial backport of core PR13235 (commit 1fabd59):
https://github.com/bitcoin/bitcoin/pull/13235/commits/1fabd59e7e870fae73bfbcfb227dd7452de94726

Depends on D4464.

Note to reviewers:
The Makefile/CMakeLists.txt change is obviously bad, because it is not
solving the circular dependency. Unfortunately solving this requires a
lot more backports that come after this one, so I leave it as is for
now.

Test Plan

make check # autotools
ninja check
ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 19 2019, 11:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2019, 11:26

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8152: Diff 14193.Nov 19 2019, 11:37

Go on, trash my ccache :)

This revision is now accepted and ready to land.Nov 19 2019, 13:39

After breaking your depends (D4461) :)

Closed by commit rABC25f5e271799d: Break circular dependency: init -> * -> init by extracting shutdown.h (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyNov 19 2019, 14:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC25f5e271799d: Break circular dependency: init -> * -> init by extracting shutdown.h.

Fabien added a commit: rSTAGING25f5e271799d: Break circular dependency: init -> * -> init by extracting shutdown.h.Apr 7 2020, 21:43

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

Makefile.am

2 lines

Makefile.bench.include

2 lines

bench/

CMakeLists.txt

2 lines

bitcoind.cpp

3 lines

index/

2 lines

2 lines

4 lines

40 lines

interfaces/

node.cpp

1 line

qt/

bitcoingui.h

2 lines

winshutdownmonitor.cpp

2 lines

rpc/

4 lines

4 lines

13 lines

20 lines

4 lines

4 lines

wallet/

rpcwallet.cpp

5 lines

wallet.cpp

2 lines

Diff 14197

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/Makefile.bench.include

View Options

src/bench/CMakeLists.txt

View Options

src/bitcoind.cpp

View Options

src/index/base.cpp

View Options

src/index/txindex.cpp

View Options

src/init.h

View Options

src/init.cpp

View Options

src/interfaces/node.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/winshutdownmonitor.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/server.cpp

View Options

src/shutdown.h

View Options

src/shutdown.cpp

View Options

src/txdb.cpp

View Options

src/validation.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

Break circular dependency: init -> * -> init by extracting shutdown.hClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14197

src/CMakeLists.txt

src/Makefile.am

src/Makefile.bench.include

src/bench/CMakeLists.txt

src/bitcoind.cpp

src/index/base.cpp

src/index/txindex.cpp

src/init.h

src/init.cpp

src/interfaces/node.cpp

src/qt/bitcoingui.h

src/qt/winshutdownmonitor.cpp

src/rpc/mining.cpp

src/rpc/server.cpp

src/shutdown.h

src/shutdown.cpp

src/txdb.cpp

src/validation.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

Break circular dependency: init -> * -> init by extracting shutdown.h
ClosedPublic
Actions

Revision Contents
Changeset List