gui: Favor macOS show / hide action in dock menu
ClosedPublic
Actions

Authored by Fabien on Nov 19 2019, 16:37.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING082ffb71c5ce: gui: Favor macOS show / hide action in dock menu
rABC082ffb71c5ce: gui: Favor macOS show / hide action in dock menu

Summary

Note that macOS toggles between Hide and Show.

Backport of core PR14133:
https://github.com/bitcoin/bitcoin/pull/14133/files

Test Plan

Cross build for OSX.
Run bitcoin-qt and check the dock icon context menu doesn't display
the show/hide item anymore (see the screenshots from
https://github.com/bitcoin/bitcoin/pull/14133)
Tested on OSX Catalina.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 19 2019, 16:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2019, 16:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8161: Diff 14206.Nov 19 2019, 16:46

jasonbcox accepted this revision.Nov 19 2019, 20:06

This revision is now accepted and ready to land.Nov 19 2019, 20:06

Closed by commit rABC082ffb71c5ce: gui: Favor macOS show / hide action in dock menu (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyNov 20 2019, 08:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC082ffb71c5ce: gui: Favor macOS show / hide action in dock menu.

Fabien added a commit: rSTAGING082ffb71c5ce: gui: Favor macOS show / hide action in dock menu.Apr 7 2020, 21:43

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

3 lines

Diff 14218

View Options

gui: Favor macOS show / hide action in dock menuClosedPublicActions