Page MenuHomePhabricator

qt: Add GUIUtil::bringToFront
ClosedPublic

Authored by Fabien on Nov 20 2019, 09:33.

Details

Summary
The sequence show -> raise -> activateWindow is factored out to the new
function GUIUtil::bringToFront where a macOS fix is added in order to
fix #13829.

Partial backport of core PR14123 (commit 5796671)
https://github.com/bitcoin/bitcoin/pull/14123/commits/5796671e1dd8a2d0b1e750c2dce19a10af624095

Depends on D4481.

Test Plan

Build and run bitcoin-qt on OSX and Linux.
Check the dock icon is working as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added inline comments.
src/qt/guiutil.cpp
65 ↗(On Diff #14224)

See D556.

Likely due to our clang-format rule for not add indent in a namespace, git managed to cleanly merge the method in the header at the wrong place while showing no conflict.
This is something we need to pay attention in the future.

This revision is now accepted and ready to land.Nov 20 2019, 14:11
This revision was automatically updated to reflect the committed changes.