qt: Use GUIUtil::bringToFront where possible
ClosedPublic
Actions

Authored by Fabien on Nov 20 2019, 09:54.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe88246db4f00: qt: Use GUIUtil::bringToFront where possible
rABCe88246db4f00: qt: Use GUIUtil::bringToFront where possible

Summary

Partial backport of core PR14123 (commit 6fc21ac):
https://github.com/bitcoin/bitcoin/pull/14123/commits/6fc21aca6d5e16c3ece104fec8e5b3df116893b4

Depends on D4482.

Test Plan

Build and run bitcoin-qt on OSX and Linux.
Check the dock icon is working as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 20 2019, 09:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 09:54

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4484: qt: All tray menu actions call showNormalIfMinimized.Nov 20 2019, 10:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8174: Diff 14226.Nov 20 2019, 10:11

deadalnix accepted this revision.Nov 20 2019, 14:12

This revision is now accepted and ready to land.Nov 20 2019, 14:12

Closed by commit rABCe88246db4f00: qt: Use GUIUtil::bringToFront where possible (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyNov 20 2019, 16:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe88246db4f00: qt: Use GUIUtil::bringToFront where possible.

Fabien added a commit: rSTAGINGe88246db4f00: qt: Use GUIUtil::bringToFront where possible.Apr 7 2020, 21:44

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

20 lines

walletview.cpp

8 lines

Diff 14246

View Options

src/qt/bitcoingui.cpp