Page MenuHomePhabricator
Differential D4493

Pass HD path data through SignatureData
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2019, 17:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0f0b515c75a8: Pass HD path data through SignatureData
rABC0f0b515c75a8: Pass HD path data through SignatureData
Summary

This is a partial backport of Core PR13723 : https://github.com/bitcoin/bitcoin/pull/13723/commits/cad5dd2368109ec398a3b79c8b9e94dfd23f0845

Depends on D4491

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hdpathsigdata
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8189
Build 14404: Default Diff Build & Tests
Build 14403: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 20 2019, 17:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 17:36
deadalnix edited the summary of this revision. (Show Details)Nov 20 2019, 17:43
deadalnix added a parent revision: D4491: Implement key origin lookup in CWallet.
deadalnix added a child revision: D4494: Make SignPSBTInput operate on a private SignatureData object.Nov 20 2019, 17:43
teamcity added a comment.Nov 20 2019, 18:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 18:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8189: Diff 14256.Nov 20 2019, 18:36
Fabien accepted this revision.Nov 21 2019, 20:04
This revision is now accepted and ready to land.Nov 21 2019, 20:04
Closed by commit rABC0f0b515c75a8: Pass HD path data through SignatureData (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 21 2019, 23:14
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0f0b515c75a8: Pass HD path data through SignatureData.
deadalnix added a commit: rSTAGING0f0b515c75a8: Pass HD path data through SignatureData.Apr 7 2020, 21:47

Revision Contents
Changeset List

PathSize
src/
script/
2 lines
25 lines
wallet/
22 lines

Diff 14256

View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...