wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation.
ClosedPublic
Actions

Authored by deadalnix on Nov 21 2019, 14:07.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an…
rABCa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an…

Summary

wallet: Add error handling. Check return value of ParseUInt32(...) in ParseHDKeypath(...).
wallet: Add tests for ParseHDKeypath(...)

This is a backport of Core PR13712

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13712

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8213
Build 14452: Default Diff Build & Tests
Build 14451: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 21 2019, 14:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2019, 14:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4501: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool.Nov 21 2019, 14:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8213: Diff 14289.Nov 21 2019, 14:17

jasonbcox accepted this revision.Nov 21 2019, 19:43

This revision is now accepted and ready to land.Nov 21 2019, 19:43

Closed by commit rABCa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyNov 21 2019, 23:07

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an….

deadalnix added a commit: rSTAGINGa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an….Apr 7 2020, 21:47

Revision Contents
Changeset List

Path

Size

src/

util/

strencodings.cpp

4 lines

wallet/

test/

psbt_wallet_tests.cpp

89 lines

Diff 14289

View Options

src/util/strencodings.cpp