Page MenuHomePhabricator
Differential D451

Only do replay protected transactions in rawtransaction rpc
ClosedPublic
Actions

Authored by deadalnix on Aug 8 2017, 20:36.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGINGf887fe317f47: Only do replay protected transactions in rawtransaction rpc
rABCf887fe317f47: Only do replay protected transactions in rawtransaction rpc
Summary

As per title. We don't need the non replay protected ones anymore.

Test Plan

Updated tests.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 8 2017, 20:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2017, 20:36
Harbormaster completed remote builds in B701: Diff 1120.Aug 8 2017, 20:36
CCulianu edited edge metadata.Aug 8 2017, 21:03

Added an inline comment.. will review more in-depth tomorrow (to make sure it doesn't break any testsm python tests, etc), but otherwise it looks correct

src/rpc/rawtransaction.cpp
977 ↗(On Diff #1120)

Someone should really just use C++11 initializer lists here.. this is nasty to read.

I'll put up a diff to do that once we approve the changes that touch this file

CCulianu accepted this revision.Aug 9 2017, 17:49

Looks perfect, and works on top of that (all extended tests pass).

Approved.

This revision is now accepted and ready to land.Aug 9 2017, 17:49
deadalnix added inline comments.Aug 9 2017, 17:56
src/rpc/rawtransaction.cpp
977 ↗(On Diff #1120)

Thanks.

Closed by commit rABCf887fe317f47: Only do replay protected transactions in rawtransaction rpc (authored by deadalnix, committed by deadalnix). · Explain WhyAug 9 2017, 18:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
rpc/
26 lines
test/
4 lines

Diff 1131

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...