Page MenuHomePhabricator

Only do replay protected transactions in rawtransaction rpc
ClosedPublic

Authored by deadalnix on Aug 8 2017, 20:36.

Details

Summary

As per title. We don't need the non replay protected ones anymore.

Test Plan

Updated tests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
forkidrawtx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 701
Build 701: arc lint + arc unit

Event Timeline

Added an inline comment.. will review more in-depth tomorrow (to make sure it doesn't break any testsm python tests, etc), but otherwise it looks correct

src/rpc/rawtransaction.cpp
977

Someone should really just use C++11 initializer lists here.. this is nasty to read.

I'll put up a diff to do that once we approve the changes that touch this file

Looks perfect, and works on top of that (all extended tests pass).

Approved.

This revision is now accepted and ready to land.Aug 9 2017, 17:49
src/rpc/rawtransaction.cpp
977

Thanks.

This revision was automatically updated to reflect the committed changes.