Page MenuHomePhabricator
Differential D4510

test: Make bloom tests deterministic
ClosedPublic
Actions

Authored by deadalnix on Nov 22 2019, 13:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING30e956385c06: test: Make bloom tests deterministic
rABC30e956385c06: test: Make bloom tests deterministic
Summary

This is a backport of Core PR15324

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 22 2019, 13:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2019, 13:06
teamcity added a comment.Nov 22 2019, 13:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 22 2019, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8230: Diff 14326.Nov 22 2019, 13:19
Fabien accepted this revision.Nov 22 2019, 13:36
Fabien added a subscriber: Fabien.

Talked offline: The deterministic behavior is made obvious by checking a value instead of a range in the test.

This revision is now accepted and ready to land.Nov 22 2019, 13:36
Closed by commit rABC30e956385c06: test: Make bloom tests deterministic (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyNov 22 2019, 13:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC30e956385c06: test: Make bloom tests deterministic.
nakihito mentioned this in D4402: Merge #15324: test: Make bloom tests deterministic.Nov 22 2019, 18:04
deadalnix added a commit: rSTAGING30e956385c06: test: Make bloom tests deterministic.Apr 7 2020, 21:48

Revision Contents
Changeset List

PathSize
src/
7 lines
test/
20 lines
14 lines
5 lines

Diff 14328

View Options

src/random.cpp

Loading...
View Options

src/test/bloom_tests.cpp

Loading...
View Options

src/test/random_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...