Merge #15324: test: Make bloom tests deterministic
AbandonedPublic
Actions

Authored by nakihito on Nov 6 2019, 00:51.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

fae169c95e09ddf068dcaebc8170c4f41b02cf66 test: Make bloom tests deterministic (MarcoFalke)

Pull request description:

non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known.

Tree-SHA512: 4f634ff0c6adf663444f1ac504f6dbceaa46b78d697b840531977ba30006453ac559d5c21cc3eaef6d92b87d46008a34b0db6331ea3318001987fcfaec634acf

Backport of Core PR15324
https://github.com/bitcoin/bitcoin/pull/15324/

Depends on D4398

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR15324

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8016
Build 14030: Bitcoin ABC Buildbot (legacy)
Build 14029: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 6 2019, 00:51

Owners added a reviewer: Restricted Owners Package.Nov 6 2019, 00:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2019, 00:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8016: Diff 13960.Nov 6 2019, 01:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

How do you test for determinism ?

In D4402#105849, @Fabien wrote:

How do you test for determinism ?

Determinism is tested here: https://reviews.bitcoinabc.org/D4402#change-93bSpcDmaTVN

nakihito planned changes to this revision.Nov 6 2019, 21:09

Working on https://github.com/bitcoin/bitcoin/pull/15296 for a more comprehensive test plan.

See D4510.

Revision Contents
Changeset List

Path

Size

src/

random.cpp

4 lines

test/

bloom_tests.cpp

20 lines

random_tests.cpp

14 lines

test_bitcoin.h

5 lines

Diff 13960

View Options

src/random.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/random_tests.cpp

View Options

Merge #15324: test: Make bloom tests deterministicAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13960

src/random.cpp

src/test/bloom_tests.cpp

src/test/random_tests.cpp

src/test/test_bitcoin.h

Merge #15324: test: Make bloom tests deterministic
AbandonedPublic
Actions

Revision Contents
Changeset List