Page MenuHomePhabricator

Merge #15324: test: Make bloom tests deterministic
Changes PlannedPublic

Authored by nakihito on Wed, Nov 6, 00:51.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

fae169c95e09ddf068dcaebc8170c4f41b02cf66 test: Make bloom tests deterministic (MarcoFalke)

Pull request description:

non-deterministic tests are useless, since a failing test could not be reproduced unless the seed is known.

Tree-SHA512: 4f634ff0c6adf663444f1ac504f6dbceaa46b78d697b840531977ba30006453ac559d5c21cc3eaef6d92b87d46008a34b0db6331ea3318001987fcfaec634acf

Backport of Core PR15324
https://github.com/bitcoin/bitcoin/pull/15324/

Depends on D4398

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15324
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8016
Build 14030: Bitcoin ABC Buildbot
Build 14029: arc lint + arc unit

Event Timeline

nakihito created this revision.Wed, Nov 6, 00:51
Owners added a reviewer: Restricted Owners Package.Wed, Nov 6, 00:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 00:51
Fabien added a comment.Wed, Nov 6, 10:25

How do you test for determinism ?

nakihito added a comment.Wed, Nov 6, 19:47

How do you test for determinism ?

Determinism is tested here: https://reviews.bitcoinabc.org/D4402#change-93bSpcDmaTVN

nakihito planned changes to this revision.Wed, Nov 6, 21:09
nakihito added a comment.Thu, Nov 7, 19:14

Working on https://github.com/bitcoin/bitcoin/pull/15296 for a more comprehensive test plan.