Page MenuHomePhabricator
Differential D4399

Encapsulate RNGState better
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 23:07.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6340d95de04d: Encapsulate RNGState better
rABC6340d95de04d: Encapsulate RNGState better
Summary

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/cddb31bb0a132afa50b5350196cf26f0064fe3e2

Depends on D4398

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 5 2019, 23:07
Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 23:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 23:07
nakihito added a child revision: D4400: Use secure allocator for RNG state.Nov 5 2019, 23:08
teamcity added a comment.Nov 5 2019, 23:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 5 2019, 23:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8010: Diff 13951.Nov 5 2019, 23:29
Fabien accepted this revision.Nov 6 2019, 10:04

The while thing could use size_t instead of int, but it's outside the scope of this PR.

This revision is now accepted and ready to land.Nov 6 2019, 10:04
Closed by commit rABC6340d95de04d: Encapsulate RNGState better (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 18:59
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC6340d95de04d: Encapsulate RNGState better.
nakihito added a commit: rSTAGING6340d95de04d: Encapsulate RNGState better.Apr 7 2020, 21:39

Revision Contents
Changeset List

PathSize
src/
9 lines

Diff 14005

View Options

src/random.cpp

Loading...