Integrate util/system's CInit into RNGState
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:58.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING49ceff8b4b78: Integrate util/system's CInit into RNGState
rABC49ceff8b4b78: Integrate util/system's CInit into RNGState

Summary

This guarantees that OpenSSL is initialized properly whenever randomness
is used, even when that randomness is invoked from global constructors.

Note that this patch uses Mutex directly, rather than CCriticalSection.
This is because the lock-detection code is not necessarily initialized
during global constructors.

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/16e40a8b562ad849a5f5e8b21ceb375e46038243

Depends on D4393

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 5 2019, 22:58

Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4395: Switch all RNG code to the built-in PRNG..Nov 5 2019, 23:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8005: Diff 13946.Nov 5 2019, 23:14

jasonbcox accepted this revision.Nov 5 2019, 23:33

This revision is now accepted and ready to land.Nov 5 2019, 23:33

Rebased.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8033: Diff 13992.Nov 8 2019, 17:26

Closed by commit rABC49ceff8b4b78: Integrate util/system's CInit into RNGState (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 17:53

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC49ceff8b4b78: Integrate util/system's CInit into RNGState.

nakihito added a commit: rSTAGING49ceff8b4b78: Integrate util/system's CInit into RNGState.Apr 7 2020, 21:38

Revision Contents
Changeset List

Path

Size

src/

random.cpp

48 lines

util/

system.cpp

49 lines

Diff 13999

View Options

src/random.cpp