Page MenuHomePhabricator
Differential D4520

[tests] Remove 'account' API from wallet_basic
ClosedPublic
Actions

Authored by nakihito on Nov 23 2019, 02:15.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd5a5598bee32: [tests] Remove 'account' API from wallet_basic
rABCd5a5598bee32: [tests] Remove 'account' API from wallet_basic
Summary

Removes usage of account API from the following functional tests:

  • wallet_basic.py

Partial backport of Core PR13075
https://github.com/bitcoin/bitcoin/pull/13075/commits/5d536619abda745c298fd827a856df775f223241#diff-02ae125bb09504d8766277c965a739f9

Test Plan
test_runner.py wallet_basic

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Nov 23 2019, 02:15
Owners added a reviewer: Restricted Owners Package.Nov 23 2019, 02:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2019, 02:15
teamcity added a comment.Nov 23 2019, 02:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 23 2019, 02:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8245: Diff 14345.Nov 23 2019, 02:25
deadalnix requested changes to this revision.Nov 23 2019, 15:06
deadalnix added inline comments.
test/functional/wallet_basic.py
402 ↗(On Diff #14345)

Fix formatting

This revision now requires changes to proceed.Nov 23 2019, 15:06
nakihito updated this revision to Diff 14389.Nov 25 2019, 18:18

Fixed comment formatting.

teamcity added a comment.Nov 25 2019, 19:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 19:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8273: Diff 14389.Nov 25 2019, 19:30
deadalnix accepted this revision.Nov 25 2019, 22:22
This revision is now accepted and ready to land.Nov 25 2019, 22:22
Closed by commit rABCd5a5598bee32: [tests] Remove 'account' API from wallet_basic (authored by nakihito). · Explain WhyNov 25 2019, 22:37
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCd5a5598bee32: [tests] Remove 'account' API from wallet_basic.
nakihito added a commit: rSTAGINGd5a5598bee32: [tests] Remove 'account' API from wallet_basic.Apr 7 2020, 21:51

Revision Contents
Changeset List

PathSize
test/
functional/
37 lines

Diff 14411

View Options

test/functional/wallet_basic.py

Loading...