Page MenuHomePhabricator
Differential D4523

[tests] Remove 'account' API from wallet_listsinceblock
ClosedPublic
Actions

Authored by nakihito on Nov 23 2019, 02:53.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf4586efbca0b: [tests] Remove 'account' API from wallet_listsinceblock
rABCf4586efbca0b: [tests] Remove 'account' API from wallet_listsinceblock
Summary

Removes usage of account API from the following functional tests:

  • wallet_listsinceblock.py

Partial backport of Core PR13075
https://github.com/bitcoin/bitcoin/pull/13075/commits/5d536619abda745c298fd827a856df775f223241#diff-22d0300fc7a3006ded2ffa33a91d28dd

Test Plan
test_runner.py wallet_listsinceblock

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 23 2019, 02:53
Owners added a reviewer: Restricted Owners Package.Nov 23 2019, 02:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2019, 02:53
teamcity added a comment.Nov 23 2019, 02:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 23 2019, 02:58

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8248: Diff 14349!Nov 23 2019, 02:58
deadalnix requested changes to this revision.Nov 23 2019, 15:03

Check the test suite.

This revision now requires changes to proceed.Nov 23 2019, 15:03
teamcity added a comment.Nov 25 2019, 20:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 20:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Nov 25 2019, 21:53
deadalnix accepted this revision.Nov 25 2019, 22:19
This revision is now accepted and ready to land.Nov 25 2019, 22:19
teamcity added a comment.Nov 25 2019, 23:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 23:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8248: Diff 14349.Nov 25 2019, 23:27
Closed by commit rABCf4586efbca0b: [tests] Remove 'account' API from wallet_listsinceblock (authored by nakihito). · Explain WhyNov 25 2019, 23:35
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCf4586efbca0b: [tests] Remove 'account' API from wallet_listsinceblock.
nakihito added a commit: rSTAGINGf4586efbca0b: [tests] Remove 'account' API from wallet_listsinceblock.Apr 7 2020, 21:51

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 14417

View Options

test/functional/wallet_listsinceblock.py

Loading...