Page MenuHomePhabricator

IsReachable is the inverse of IsLimited (DRY). Includes unit tests
ClosedPublic

Authored by deadalnix on Nov 25 2019, 15:20.

Details

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 25 2019, 15:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 15:20
Fabien requested changes to this revision.Nov 25 2019, 15:36
Fabien added a subscriber: Fabien.

A few nits, otherwise looks good.

src/test/net_tests.cpp
263 ↗(On Diff #14367)

Nit: comment on it's own line

270 ↗(On Diff #14367)

As per promag's comment, can be static

274 ↗(On Diff #14367)

Dito

280 ↗(On Diff #14367)

Dito

291 ↗(On Diff #14367)

Dito

296 ↗(On Diff #14367)

Dito

This revision now requires changes to proceed.Nov 25 2019, 15:36
deadalnix updated this revision to Diff 14369.Nov 25 2019, 16:07

Nits in the test

Fabien accepted this revision.Nov 25 2019, 16:22

The static suggestion remains

This revision is now accepted and ready to land.Nov 25 2019, 16:22