IsReachable is the inverse of IsLimited (DRY). Includes unit tests
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2019, 15:20.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests
rABCbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests

Summary

This is a backport of Core PR15051

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15051

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8260
Build 14545: Default Diff Build & Tests
Build 14544: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2019, 15:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 15:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

A few nits, otherwise looks good.

src/test/net_tests.cpp
263	Nit: comment on it's own line
270	As per promag's comment, can be static
274	Dito
280	Dito
291	Dito
296	Dito

This revision now requires changes to proceed.Nov 25 2019, 15:36

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8260: Diff 14367!Nov 25 2019, 15:37

Nits in the test

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8261: Diff 14369.Nov 25 2019, 16:17

The static suggestion remains

This revision is now accepted and ready to land.Nov 25 2019, 16:22

Closed by commit rABCbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests (authored by marcaiaf <mmachicao@m19r.de>, committed by deadalnix). · Explain WhyNov 25 2019, 17:07

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests.

deadalnix added a commit: rSTAGINGbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests.Apr 7 2020, 21:49

Revision Contents
Changeset List

Path

Size

src/

net.cpp

6 lines

test/

net_tests.cpp

82 lines

Diff 14367

View Options

src/net.cpp