Page MenuHomePhabricator
Differential D4533

IsReachable is the inverse of IsLimited (DRY). Includes unit tests
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2019, 15:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests
rABCbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests
Summary

This is a backport of Core PR15051

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15051
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8261
Build 14547: Default Diff Build & Tests
Build 14546: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2019, 15:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 15:20
teamcity added a comment.Nov 25 2019, 15:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien requested changes to this revision.Nov 25 2019, 15:36
Fabien added a subscriber: Fabien.

A few nits, otherwise looks good.

src/test/net_tests.cpp
263 ↗(On Diff #14367)

Nit: comment on it's own line

270 ↗(On Diff #14367)

As per promag's comment, can be static

274 ↗(On Diff #14367)

Dito

280 ↗(On Diff #14367)

Dito

291 ↗(On Diff #14367)

Dito

296 ↗(On Diff #14367)

Dito

This revision now requires changes to proceed.Nov 25 2019, 15:36
teamcity added a comment.Nov 25 2019, 15:37

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8260: Diff 14367!Nov 25 2019, 15:37
deadalnix updated this revision to Diff 14369.Nov 25 2019, 16:07

Nits in the test

teamcity added a comment.Nov 25 2019, 16:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 16:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8261: Diff 14369.Nov 25 2019, 16:17
Fabien accepted this revision.Nov 25 2019, 16:22

The static suggestion remains

This revision is now accepted and ready to land.Nov 25 2019, 16:22
Closed by commit rABCbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests (authored by marcaiaf <mmachicao@m19r.de>, committed by deadalnix). · Explain WhyNov 25 2019, 17:07
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests.
deadalnix added a commit: rSTAGINGbb1e0b46815f: IsReachable is the inverse of IsLimited (DRY). Includes unit tests.Apr 7 2020, 21:49

Revision Contents
Changeset List

PathSize
src/
6 lines
test/
85 lines

Diff 14369

View Options

src/net.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...