Page MenuHomePhabricator
Differential D455

Always sign using replay protection
ClosedPublic
Actions

Authored by deadalnix on Aug 9 2017, 17:53.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGINGc16aa316833e: Always sign using replay protection
rABCc16aa316833e: Always sign using replay protection
Summary

Now that the fork happened, we need to use replay protected transactions all the time. Doing otherwize will just create the opportunity to lose funds.

Test Plan
make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
signforkid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 709
Build 709: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 9 2017, 17:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2017, 17:53
Harbormaster completed remote builds in B709: Diff 1128.Aug 9 2017, 17:53
CCulianu accepted this revision.Aug 10 2017, 09:14

This looks correct to me and I can't think of any place you "missed a spot".

Tests check out. Approving so we can move forward..

This revision is now accepted and ready to land.Aug 10 2017, 09:14
Closed by commit rABCc16aa316833e: Always sign using replay protection (authored by deadalnix, committed by deadalnix). · Explain WhyAug 10 2017, 10:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
5 lines
test_framework/
4 lines
src/
script/
30 lines
test/
6 lines
54 lines
6 lines
wallet/
2 lines

Diff 1128

View Options

qa/rpc-tests/fundrawtransaction.py

Loading...
View Options

qa/rpc-tests/test_framework/util.py

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/test/multisig_tests.cpp

Loading...
View Options

src/test/script_P2SH_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...