Page MenuHomePhabricator

[tests] make pruning test faster

Authored by Fabien on Nov 27 2019, 11:16.


Group Reviewers
Restricted Project
rABC705004cee429: [tests] make pruning test faster
This commit makes the much faster.

Key insights to do this:

- doesn't care what kind of transactions make up the big
blocks that are pruned in the test. Instead of making blocks with
several large, expensive to construct and validate transactions,
instead make the large blocks contain a single coinbase transaction with
a huge OP_RETURN txout.
- avoid stop-starting nodes where possible.

This test could probably be made even faster by using the P2P interface
for submitting blocks instead of the submitblock RPC.

Completes backport of core PR15686 (commit 03d6d23):

Depends on D4561.

Test Plan
./test/functional/ feature_pruning

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Nov 27 2019, 11:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2019, 11:16
deadalnix accepted this revision.Nov 27 2019, 17:04
This revision is now accepted and ready to land.Nov 27 2019, 17:04
This revision was automatically updated to reflect the committed changes.