Page MenuHomePhabricator

Minor improvements to add_nodes
ClosedPublic

Authored by Fabien on Wed, Nov 27, 10:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe7e1aab6b0b6: Minor improvements to add_nodes
Summary

This is a backport of core PR14805 and PR14951.
Since the first one add a feature and the second reverts it, the
remaining is a refactor-only commit that improves the docstring for
add_nodes() and cuts a long line to improve readability:
https://github.com/bitcoin/bitcoin/pull/14951/commits/fa4b8c90d3d13c7382357ee9f75df4f4974aef20

Depends on D4557.

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Nov 27, 10:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 27, 10:32
deadalnix accepted this revision.Wed, Nov 27, 16:57
This revision is now accepted and ready to land.Wed, Nov 27, 16:57
This revision was automatically updated to reflect the committed changes.