Paths

Table of Contentst

Differential D4559

Minor improvements to add_nodes
ClosedPublic
Actions

Authored by Fabien on Nov 27 2019, 10:32.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe7e1aab6b0b6: Minor improvements to add_nodes
rABCe7e1aab6b0b6: Minor improvements to add_nodes

Summary

This is a backport of core PR14805 and PR14951.
Since the first one add a feature and the second reverts it, the
remaining is a refactor-only commit that improves the docstring for
add_nodes() and cuts a long line to improve readability:
https://github.com/bitcoin/bitcoin/pull/14951/commits/fa4b8c90d3d13c7382357ee9f75df4f4974aef20

Depends on D4557.

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14951

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8305
Build 14629: Default Diff Build & Tests
Build 14628: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 27 2019, 10:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2019, 10:32

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4560: [test] Rename rpc_timewait to rpc_timeout.Nov 27 2019, 10:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8305: Diff 14450.Nov 27 2019, 10:48

deadalnix accepted this revision.Nov 27 2019, 16:57

This revision is now accepted and ready to land.Nov 27 2019, 16:57

Closed by commit rABCe7e1aab6b0b6: Minor improvements to add_nodes (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 27 2019, 20:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe7e1aab6b0b6: Minor improvements to add_nodes.

Fabien added a commit: rSTAGINGe7e1aab6b0b6: Minor improvements to add_nodes.Apr 7 2020, 21:52

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

22 lines

Diff 14450

test/functional/test_framework/test_framework.py

Loading...