Page MenuHomePhabricator

Merge #15149: gui: Show current wallet name in window title
ClosedPublic

Authored by jasonbcox on Wed, Nov 27, 20:23.

Details

Summary

fe7048b39 gui: Show current wallet name in window title (João Barbosa)
8a7926112 gui: Keep network style in BitcoinGUI (João Barbosa)
f411c8b35 gui: Remove unused return type in some BitcoinGUI methods (João Barbosa)

Pull request description:

<img width="876" alt="screenshot 2019-01-11 at 23 58 26" src="https://user-images.githubusercontent.com/3534524/51065458-d7ebaf80-15fc-11e9-9162-e37e9a10d448.png">

Tree-SHA512: 5c43f615834983bc1c5045e07c6e119044dd78ca947fd2679d302b519d5ce1d08d29ca00b1c11e88c4bbc4d56f2e6f4a8adc42084f3503e751e642e8a13112dc

Backport of Core PR15149
https://github.com/bitcoin/bitcoin/pull/15149/files

Depends on D4567
Completes T699

Test Plan

ninja check
Verify bitcoin-qt shows wallet name in window title.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Wed, Nov 27, 20:23
jasonbcox edited the test plan for this revision. (Show Details)Wed, Nov 27, 20:24
Fabien accepted this revision.Wed, Nov 27, 20:42
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/bitcoingui.cpp
76 ↗(On Diff #14470)

Nit: put config before platform to keep ordering consistent

This revision is now accepted and ready to land.Wed, Nov 27, 20:42
jasonbcox updated this revision to Diff 14474.Wed, Nov 27, 21:52
  • Rebase
  • changed member initializer ordering per feedback
  • removed enableWallet(false) which was erroneously left in D1959
Fabien accepted this revision.Thu, Nov 28, 06:34