Page MenuHomePhabricator

Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
ClosedPublic

Authored by majcosta on Nov 27 2019, 23:02.

Details

Summary

This is a backport of Core PR14728

As above. https://github.com/bitcoin/bitcoin/pull/14728

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
second-backport
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8319
Build 14657: Default Diff Build & Tests
Build 14656: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Nov 27 2019, 23:02
deadalnix requested changes to this revision.Nov 27 2019, 23:11
deadalnix added inline comments.
src/netaddress.h
34 ↗(On Diff #14475)

Revert

73 ↗(On Diff #14475)

dito

This revision now requires changes to proceed.Nov 27 2019, 23:11
This revision is now accepted and ready to land.Nov 27 2019, 23:39

Keep in mind to mention PR12354936 in the diff sum up so people can grep for it easily.

You can also indent commands with double space rather than use backticks.

like this

removed declaration not in our codebase