Differential D4582

Move pindexFinalized in CChainState
ClosedPublic
Actions

Authored by deadalnix on Nov 29 2019, 15:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING0dde45fa7ec5: Move pindexFinalized in CChainState
rABC0dde45fa7ec5: Move pindexFinalized in CChainState

Summary

As per title. This is a chain state and there are no reason for it not to be in there.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pindexfinalizedstate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8334
Build 14687: Default Diff Build & Tests
Build 14686: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 29 2019, 15:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2019, 15:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8334: Diff 14505.Nov 29 2019, 15:33

Fabien requested changes to this revision.Nov 29 2019, 20:23

Fabien added a subscriber: Fabien.

This comment was removed by Fabien.

This revision now requires changes to proceed.Nov 29 2019, 20:23

Fabien accepted this revision.Nov 29 2019, 20:24

This revision is now accepted and ready to land.Nov 29 2019, 20:24

Closed by commit rABC0dde45fa7ec5: Move pindexFinalized in CChainState (authored by deadalnix). · Explain WhyNov 29 2019, 23:10

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0dde45fa7ec5: Move pindexFinalized in CChainState.

deadalnix added a commit: rSTAGING0dde45fa7ec5: Move pindexFinalized in CChainState.Apr 7 2020, 21:55

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

3 lines

Diff 14505

View Options

Move pindexFinalized in CChainStateClosedPublicActions