Paths

Table of Contentst

Differential D4595

Introduce BlockHash to represent a block hash
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 03:01.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1450d42778b0: Introduce BlockHash to represent a block hash
rABC1450d42778b0: Introduce BlockHash to represent a block hash

Summary

So far we've been using raw uint256 for block hashes. Many things in bitcoin are uint256, such as transaction ids, merkle root, sighash, and so on.

Using a dedicated type ensures greater type safety and allows to make API more specific.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

blockhash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8349
Build 14717: Default Diff Build & Tests
Build 14716: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 30 2019, 03:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 03:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

Update copyright year

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8349: Diff 14526.Nov 30 2019, 03:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8350: Diff 14527.Nov 30 2019, 03:21

Fabien requested changes to this revision.Nov 30 2019, 14:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

contrib/devtools/chainparams/generate_chainparams_constants.py
52 ↗	(On Diff #14527)	Keep for chainwork
56 ↗	(On Diff #14527)	Chainwork is not a block hash
59 ↗	(On Diff #14527)	Dito
src/consensus/params.h
9 ↗	(On Diff #14527)	Even if included indirectly by `primitives/blockhash.h`, you should keep it for `nMinimumChainWork` so that if won't break the build if the inclusion is removed from `primitives/blockhash.h`.
src/primitives/block.h
11 ↗	(On Diff #14527)	Keep for `hashMerkleRoot`
src/rpc/blockchain.cpp
826 ↗	(On Diff #14527)	Can use `fromHex()`
937 ↗	(On Diff #14527)	Dito
1561 ↗	(On Diff #14527)	Dito
1598 ↗	(On Diff #14527)	Dito
1639 ↗	(On Diff #14527)	That will be the same for all RPCs
src/test/coins_tests.cpp
9 ↗	(On Diff #14527)	Missing `<primitives/blockhash.h>` ?
src/wallet/rpcwallet.cpp
2675 ↗	(On Diff #14527)	Use `fromHex()`

This revision now requires changes to proceed.Nov 30 2019, 14:49

deadalnix added inline comments.Nov 30 2019, 16:31

contrib/devtools/chainparams/generate_chainparams_constants.py
52 ↗	(On Diff #14527)	Good catch.
56 ↗	(On Diff #14527)	You are correct
src/rpc/blockchain.cpp
826 ↗	(On Diff #14527)	It's just more verbose, and does the same.
src/test/coins_tests.cpp
9 ↗	(On Diff #14527)	It's not needed.

Update

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Nov 30 2019, 17:07

This revision is now accepted and ready to land.Nov 30 2019, 17:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8351: Diff 14531.Nov 30 2019, 17:18

Closed by commit rABC1450d42778b0: Introduce BlockHash to represent a block hash (authored by deadalnix). · Explain WhyNov 30 2019, 17:33

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1450d42778b0: Introduce BlockHash to represent a block hash.

deadalnix added a commit: rSTAGING1450d42778b0: Introduce BlockHash to represent a block hash.Apr 7 2020, 21:55

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

chainparams/

generate_chainparams_constants.py

10 lines

src/

4 lines

blockencodings.h

2 lines

18 lines

2 lines

2 lines

chainparams.cpp

117 lines

chainparamsconstants.h

8 lines

checkpoints.cpp

5 lines

26 lines

22 lines

consensus/

11 lines

index/

2 lines

2 lines

6 lines

2 lines

net_processing.cpp

39 lines

primitives/

12 lines

4 lines

24 lines

12 lines

rpc/

25 lines

4 lines

rawtransaction.cpp

10 lines

test/

avalanche_tests.cpp

18 lines

blockencodings_tests.cpp

6 lines

blockindex_tests.cpp

13 lines

checkpoints_tests.cpp

8 lines

coins_tests.cpp

9 lines

miner_tests.cpp

4 lines

skiplist_tests.cpp

13 lines

2 lines

validation_block_tests.cpp

9 lines

12 lines

23 lines

2 lines

34 lines

wallet/

4 lines

test/

wallet_tests.cpp

2 lines

9 lines

4 lines

Diff 14526

contrib/devtools/chainparams/generate_chainparams_constants.py

Loading...

src/avalanche.cpp

Loading...

src/blockencodings.h

Loading...

src/chain.h

Loading...

src/chain.cpp

Loading...

src/chainparams.h

Loading...

src/chainparams.cpp

Loading...

src/chainparamsconstants.h

Loading...

src/checkpoints.h

Loading...

src/checkpoints.cpp

Loading...

src/coins.h

Loading...

src/coins.cpp

Loading...

src/consensus/params.h

Loading...

src/index/base.cpp

Loading...

src/init.cpp

Loading...

src/net.h

Loading...

src/net.cpp

Loading...

src/net_processing.cpp

Loading...

src/primitives/block.h

Loading...

src/primitives/block.cpp

Loading...

src/primitives/blockhash.h

Loading...

src/rest.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/test/avalanche_tests.cpp

Loading...

src/test/blockencodings_tests.cpp

Loading...

src/test/blockindex_tests.cpp

Loading...

src/test/checkpoints_tests.cpp

Loading...

src/test/coins_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/skiplist_tests.cpp

Loading...

src/test/undo_tests.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/txdb.h

Loading...

src/txdb.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...