Avoid creating a temporary vector for size-prefixed elements
ClosedPublic
Actions

Authored by deadalnix on Dec 1 2019, 01:30.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9f49375e4158: Avoid creating a temporary vector for size-prefixed elements
rABC9f49375e4158: Avoid creating a temporary vector for size-prefixed elements

Summary

This is a backport of Core PR13719

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13719

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8361
Build 14741: Default Diff Build & Tests
Build 14740: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 1 2019, 01:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2019, 01:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4606: Drop minor GetSerializeSize template.Dec 1 2019, 01:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8361: Diff 14544.Dec 1 2019, 01:47

Fabien accepted this revision.Dec 2 2019, 08:41

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/serialize.h
1002	This needs a rebase on top of D4603, or the opposite.

This revision is now accepted and ready to land.Dec 2 2019, 08:41

Closed by commit rABC9f49375e4158: Avoid creating a temporary vector for size-prefixed elements (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyDec 2 2019, 13:55

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC9f49375e4158: Avoid creating a temporary vector for size-prefixed elements.

deadalnix added a commit: rSTAGING9f49375e4158: Avoid creating a temporary vector for size-prefixed elements.Apr 7 2020, 21:56

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

26 lines

serialize.h

7 lines

Diff 14544

View Options

src/script/sign.h