Drop minor GetSerializeSize template
ClosedPublic
Actions

Authored by deadalnix on Dec 1 2019, 01:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING535e7c83dd4f: Drop minor GetSerializeSize template
rABC535e7c83dd4f: Drop minor GetSerializeSize template

Summary

Now that GetType() is not propagated, the benefits are not worth the code.

This is a partial backport of Core PR13558 : https://github.com/bitcoin/bitcoin/pull/13558/commits/893628be0166b4096b6e52f516e0f65bb63a75a2

Depends on D4605 and D4603

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 1 2019, 01:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2019, 01:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8362: Diff 14545.Dec 1 2019, 02:02

Fabien accepted this revision.Dec 2 2019, 08:43

This revision is now accepted and ready to land.Dec 2 2019, 08:43

Closed by commit rABC535e7c83dd4f: Drop minor GetSerializeSize template (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyDec 2 2019, 13:58

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC535e7c83dd4f: Drop minor GetSerializeSize template.

deadalnix added a commit: rSTAGING535e7c83dd4f: Drop minor GetSerializeSize template.Apr 7 2020, 21:56

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

2 lines

serialize.h

11 lines

validation.cpp

4 lines

Diff 14559

View Options

src/script/sign.h

View Options

src/serialize.h

View Options

Drop minor GetSerializeSize templateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14559

src/script/sign.h

src/serialize.h

src/validation.cpp

Drop minor GetSerializeSize template
ClosedPublic
Actions

Revision Contents
Changeset List