Differential D4610

Make TxIndex::FindTx use BlockHash
ClosedPublic
Actions

Authored by deadalnix on Dec 1 2019, 15:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING14d47c56608e: Make TxIndex::FindTx use BlockHash
rABC14d47c56608e: Make TxIndex::FindTx use BlockHash

Summary

It's expecting a block hash, so it should accept a BlockHash.

Depends on D4609

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Dec 1 2019, 15:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2019, 15:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8368: Diff 14551.Dec 1 2019, 16:04

Fabien accepted this revision.Dec 2 2019, 08:53

This revision is now accepted and ready to land.Dec 2 2019, 08:53

Fabien retitled this revision from Make TxIndex::FindTx us BlockHash to Make TxIndex::FindTx use BlockHash.Dec 2 2019, 08:54

Closed by commit rABC14d47c56608e: Make TxIndex::FindTx use BlockHash (authored by deadalnix). · Explain WhyDec 2 2019, 14:54

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC14d47c56608e: Make TxIndex::FindTx use BlockHash.

deadalnix added a commit: rSTAGING14d47c56608e: Make TxIndex::FindTx use BlockHash.Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

index/

txindex.h

2 lines

txindex.cpp

2 lines

test/

txindex_tests.cpp

2 lines

Diff 14570

View Options

src/index/txindex.h

View Options

src/index/txindex.cpp

View Options

src/test/txindex_tests.cpp

Make TxIndex::FindTx use BlockHashClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14570

src/index/txindex.h

src/index/txindex.cpp

src/test/txindex_tests.cpp

Make TxIndex::FindTx use BlockHash
ClosedPublic
Actions

Revision Contents
Changeset List