Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required
ClosedPublic
Actions

Authored by ProtocolCash on Dec 4 2019, 18:18.

Details

Reviewers

deadalnix
jasonbcox
Mengerian

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING883501524685: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required
rABC883501524685: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required

Summary

fix outdated mention of clang-format-7

Test Plan

note that arc lint fails unless clang-format-8 is installed, even if clang-format-7 is available

Diff Detail

Repository

rABC Bitcoin ABC

Branch

contributing-doc-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8408
Build 14833: Default Diff Build & Tests
Build 14832: arc lint + arc unit

Event Timeline

ProtocolCash created this revision.Dec 4 2019, 18:18

Owners added a reviewer: Restricted Owners Package.Dec 4 2019, 18:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 18:18

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8408: Diff 14618.Dec 4 2019, 18:35

jasonbcox accepted this revision.Dec 4 2019, 18:54

This revision is now accepted and ready to land.Dec 4 2019, 18:54

Good catch!

Guess it was missed in D4551

Closed by commit rABC883501524685: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required (authored by ProtocolCash). · Explain WhyDec 5 2019, 21:45

This revision was automatically updated to reflect the committed changes.

ProtocolCash added a commit: rABC883501524685: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.

ProtocolCash added a commit: rSTAGING883501524685: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.Apr 7 2020, 22:00

Revision Contents
Changeset List

Path

Size

CONTRIBUTING.md

2 lines

Diff 14618

View Options

Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is requiredClosedPublicActions