Remove errant --testnet argument in chainparams README
ClosedPublic
Actions

Authored by jasonbcox on Dec 5 2019, 18:55.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING8776750dc21b: Remove errant --testnet argument in chainparams README
rABC8776750dc21b: Remove errant --testnet argument in chainparams README

Summary

This argument was leftover from an old design. It's no longer necessary/relevant and fails
when you copy-paste this command.

Test Plan

bitcoind --testnet
make_chainparams --testnet -a 127.0.0.1:18332 > chainparams_test.txt  # fails
make_chainparams -a 127.0.0.1:18332 > chainparams_test.txt  # successful

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixup-chainparams-readme

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8431
Build 14877: Default Diff Build & Tests
Build 14876: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 5 2019, 18:55

Herald added a reviewer: deadalnix. · View Herald TranscriptDec 5 2019, 18:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8431: Diff 14654.Dec 5 2019, 19:10

Fabien accepted this revision.Dec 5 2019, 22:12

This revision is now accepted and ready to land.Dec 5 2019, 22:12

Closed by commit rABC8776750dc21b: Remove errant --testnet argument in chainparams README (authored by jasonbcox). · Explain WhyDec 5 2019, 22:50

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC8776750dc21b: Remove errant --testnet argument in chainparams README.

jasonbcox added a commit: rSTAGING8776750dc21b: Remove errant --testnet argument in chainparams README.Apr 7 2020, 22:00

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

chainparams/

README.md

2 lines

Diff 14654

View Options

contrib/devtools/chainparams/README.md

Remove errant --testnet argument in chainparams READMEClosedPublicActions