Currently MANDATORY_SCRIPT_VERIFY_FLAGS is used in weird ways and also
its documentation is a misleading lie. I'd like to fix the craziness,
which starts with documenting it accurately.
Details
Details
- Reviewers
Mengerian deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING8e73d9061359: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately
rABC8e73d9061359: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately
read
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D4672
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8874 Build 15723: Default Diff Build & Tests Build 15722: arc lint + arc unit
Event Timeline
| src/script/standard.h | ||
|---|---|---|
| 55 ↗ | (On Diff #14708) | I don't think a listing of where this is used is a good idea ever. These place will be changed over time, but this comment will stay, providing completely misleading information. The main purpose of this set of flag is that, if you receive a transaction that is not valid as per one of these, then you can ban the peer. |
| src/script/standard.h | ||
|---|---|---|
| 55 ↗ | (On Diff #14708) | Yeah my plan is to fix all those other places which are misusing these flags, really it should only be used for a single purpose which is the one you describe (the first one in my list). In fact I'd suggest we don't even need this flagset, really we just ought to pay attention to what is in STANDARD_NOT_MANDATORY_VERIFY_FLAGS. Nonetheless, the current comment describing this flag is simply wrong. |