This is a work in progress, posted to phabricator so freetrader and others can see it
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- no_fork_warning
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 726 Build 726: arc lint + arc unit
Event Timeline
Comment Actions
FYI; the CheckForkWarningConditions() and friends use hard-coded block-counts and show a warning of a nature that I'm not sure is of any value. As such this code has been removed in Classic.
Comment Actions
Yeah, I noticed you guys did away with it.
I can't reproduce this at all. I tried various things such as running the Core client to build a long legacy chain then switching the Bitcoin ABC to have a "long invalid fork"
People that reported the bug said it went away on its own as the cash chain grew. Only in the first days of the fork were they reporting it, and only if they ran Core first to build a legacy chain after the fork.
I'm going to close this for now. I can't reproduce it, I can't test it, and deadalnix is conservative about removing the warning altogether without testing.