Page MenuHomePhabricator
Differential D4689

Merge #13500: [wallet] Decouple wallet version from client version
ClosedPublic
Actions

Authored by nakihito on Dec 10 2019, 20:13.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGcb35659a7f2e: Merge #13500: [wallet] Decouple wallet version from client version
rABCcb35659a7f2e: Merge #13500: [wallet] Decouple wallet version from client version
Summary

cd3f4aa80810fc077c7f9528a4ef53c1438c86e1 Decouple wallet version from client version (Andrew Chow)

Pull request description:

Instead of comparing version numbers in the wallet to the client version number, compare them to the latest supported wallet version in the client. This allows for wallet version numbers to be unrelated to the client version number.

Tree-SHA512: 69c3e1f45a40bde01d622d504a803fea32fc14e2e27b14b0729725349d8592d56ebca26fd06f117fd6f5164fb4ce980122751b6370f6e25f1a947dbdf4143ddd

Backport of Core PR13500
https://github.com/bitcoin/bitcoin/pull/13500/

Test Plan
make check
./bitcoind

Edit wallet/wallet.h line 94 from

FEATURE_LATEST = FEATURE_PRE_SPLIT_KEYPOOL,

to

FEATURE_LATEST = FEATURE_BASE,

Ensure bitcoind crashes with the following error:

2019-12-10T20:45:15Z Error: Error loading : Wallet requires newer version of Bitcoin ABC
Error: Error loading : Wallet requires newer version of Bitcoin ABC

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Dec 10 2019, 20:13
Owners added a reviewer: Restricted Owners Package.Dec 10 2019, 20:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 20:13
nakihito planned changes to this revision.Dec 10 2019, 20:13
teamcity added a comment.Dec 10 2019, 20:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 10 2019, 20:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8483: Diff 14736.Dec 10 2019, 20:26
nakihito requested review of this revision.Dec 10 2019, 20:47
nakihito edited the test plan for this revision. (Show Details)
Fabien accepted this revision.Dec 10 2019, 21:15
This revision is now accepted and ready to land.Dec 10 2019, 21:15
Closed by commit rABCcb35659a7f2e: Merge #13500: [wallet] Decouple wallet version from client version (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyDec 10 2019, 21:24
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCcb35659a7f2e: Merge #13500: [wallet] Decouple wallet version from client version.
nakihito added a commit: rSTAGINGcb35659a7f2e: Merge #13500: [wallet] Decouple wallet version from client version.Apr 7 2020, 22:01

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
4 lines

Diff 14742

View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...