Page MenuHomePhabricator

[UBSAN] Update exceptions
ClosedPublic

Authored by Fabien on Dec 12 2019, 14:07.

Details

Summary

This diff adds a new sanitizer exception entry to avoid a vptr issue
caused by the boost test case timeout in the avalanche unit test
poll_inflight_timeout. For some unknown reason this issue only
triggers when building with cmake, and only with clang 7 (8 and 9 are
OK).

Test Plan
mkdir -p buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_C_COMPILER=clang-7 -DCMAKE_CXX_COMPILER=clang++-7 -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=undefined
ninja
export UBSAN_OPTIONS="suppressions=../sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1"
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ubsan_update_exceptions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8521
Build 15041: Default Diff Build & Tests
Build 15040: arc lint + arc unit

Event Timeline

Fabien planned changes to this revision.Dec 12 2019, 15:49
Fabien edited the test plan for this revision. (Show Details)

Don't remove the functional test.

jasonbcox added a subscriber: jasonbcox.

The docs make no mention of comments working in the suppressions file, but it would be nice if we could comment this line that it only affects builds using clang-7

This revision is now accepted and ready to land.Dec 12 2019, 17:15
This revision was automatically updated to reflect the committed changes.