Page MenuHomePhabricator
Differential D4709

[CMAKE] Fix FindBerkeleyDB for FreeBSD
ClosedPublic
Actions

Authored by Fabien on Dec 12 2019, 15:37.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING53070e930d56: [CMAKE] Fix FindBerkeleyDB for FreeBSD
rABC53070e930d56: [CMAKE] Fix FindBerkeleyDB for FreeBSD
Summary

The files are located under /usr/local/<include|lib>/db5/ on FreeBSD 12.
Using PATH_SUFFIXES allow to search with the db5 directory in the
path.

Test Plan

On FreeBSD (tested on FreeBSD 12):

cmake -GNinja -DBUILD_BITCOIN_QT=OFF ..

Check that cmake finds the library.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_freebsd_bdb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8522
Build 15043: Default Diff Build & Tests
Build 15042: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 12 2019, 15:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2019, 15:37
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 12 2019, 15:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien mentioned this in D4710: [CMAKE] SYS_getrandom is expected to be linux only.Dec 12 2019, 15:40
teamcity added a comment.Dec 12 2019, 15:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8522: Diff 14798.Dec 12 2019, 15:48
jasonbcox accepted this revision.Dec 12 2019, 17:36
This revision is now accepted and ready to land.Dec 12 2019, 17:36
Fabien edited the summary of this revision. (Show Details)Dec 13 2019, 07:31
Closed by commit rABC53070e930d56: [CMAKE] Fix FindBerkeleyDB for FreeBSD (authored by Fabien). · Explain WhyDec 13 2019, 07:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC53070e930d56: [CMAKE] Fix FindBerkeleyDB for FreeBSD.
Fabien mentioned this in rABCd98efd8b2cdc: [CMAKE] SYS_getrandom is expected to be linux only.
Fabien added a commit: rSTAGING53070e930d56: [CMAKE] Fix FindBerkeleyDB for FreeBSD.Apr 7 2020, 22:04
Fabien mentioned this in rSTAGINGd98efd8b2cdc: [CMAKE] SYS_getrandom is expected to be linux only.

Revision Contents
Changeset List

PathSize
cmake/
modules/
4 lines

Diff 14798

View Options

cmake/modules/FindBerkeleyDB.cmake

Loading...