Merge #13633: Drop dead code from Stacks
ClosedPublic
Actions

Authored by nakihito on Dec 13 2019, 20:46.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING06265e7af0c3: Merge #13633: Drop dead code from Stacks
rABC06265e7af0c3: Merge #13633: Drop dead code from Stacks

Summary

5617840392dad8c00c0e4216f1a536daaa9dd4bd Drop dead code from Stacks (Ben Woosley)

Pull request description:

Stacks is local to this file, and only used in DataFromTransaction, so
it's easy to confirm this code is unused.

Tree-SHA512: cc680c99f9b31cb56db70f453087d642f83906ce594c07a6bf3e61427cfbee41441495d440b240419ba3386582cf0670c0999b2f51e7fd56b00e0a0f3f618845

Backport of Core PR13633
https://github.com/bitcoin/bitcoin/pull/13633/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Dec 13 2019, 20:46

Owners added a reviewer: Restricted Owners Package.Dec 13 2019, 20:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2019, 20:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8559: Diff 14857.Dec 13 2019, 20:57

jasonbcox accepted this revision.Dec 13 2019, 21:08

This revision is now accepted and ready to land.Dec 13 2019, 21:08

Closed by commit rABC06265e7af0c3: Merge #13633: Drop dead code from Stacks (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyDec 13 2019, 22:45

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC06265e7af0c3: Merge #13633: Drop dead code from Stacks.

nakihito added a commit: rSTAGING06265e7af0c3: Merge #13633: Drop dead code from Stacks.Apr 7 2020, 22:04

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

11 lines

Diff 14859

View Options

Merge #13633: Drop dead code from StacksClosedPublicActions