I ran UBSAN on the tests and this was one of the easier fixes. Bitcoin compiles as a 32-bit app and as such this usage ends up with an overflow. Note that this bug isn't super-critical as the GetPerformanceCounter() function is only used to seed random number generators, but it still is a bug nonetheless.
Details
Details
- Reviewers
freetrader deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING65987b1ab815: Fixed overflow in GetPerformanceCounter()
rABC65987b1ab815: Fixed overflow in GetPerformanceCounter()
make check and rpc-tests.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Modified to be minimally required expression syntax to have all types auto-promoted to int64