Page MenuHomePhabricator
Differential D4735

qt: Replace objc_msgSend with native syntax
ClosedPublic
Actions

Authored by Fabien on Dec 16 2019, 20:12.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING7215bb784bf3: qt: Replace objc_msgSend with native syntax
rABC7215bb784bf3: qt: Replace objc_msgSend with native syntax
Summary

Fix the build on MacOS Catalina (require D4734).

Backport of core PR16720:
https://github.com/bitcoin/bitcoin/pull/16720/files

Test Plan

Build on OSX.
Run the OSX gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16720
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8574
Build 15138: Default Diff Build & Tests
Build 15137: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 16 2019, 20:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 16 2019, 20:12
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 16 2019, 20:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 16 2019, 20:13

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Dec 16 2019, 20:17

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Dec 16 2019, 20:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8574: Diff 14879.Dec 16 2019, 20:23
jasonbcox accepted this revision.Dec 16 2019, 22:22
This revision is now accepted and ready to land.Dec 16 2019, 22:22
Closed by commit rABC7215bb784bf3: qt: Replace objc_msgSend with native syntax (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 17 2019, 09:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7215bb784bf3: qt: Replace objc_msgSend with native syntax.
Fabien added a commit: rSTAGING7215bb784bf3: qt: Replace objc_msgSend with native syntax.Apr 7 2020, 22:06

Revision Contents
Changeset List

PathSize
2 lines
src/
2 lines
qt/
9 lines
22 lines

Diff 14879

View Options

configure.ac

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/macdockiconhandler.mm

Loading...