Page MenuHomePhabricator

Fetch and check signature and sha256sum of debian ISO instead of comparing against a hardcoded hash
ClosedPublic

Authored by jasonbcox on Dec 17 2019, 19:43.

Details

Summary

See title. This is easier to maintain since version bumps only need to modify the first line.

Test Plan

Copy-paste these commands and run them.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested changes to this revision.Dec 17 2019, 19:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/gitian-building/gitian-building-create-vm-debian.md
77 ↗(On Diff #14930)

grep "debian-${DEBIAN_VERSION}-amd64-netinst.iso" SHA256SUMS | sha256sum -c

This revision now requires changes to proceed.Dec 17 2019, 19:57

Fixed according to feedback + updated the instructions text above the commands.

This revision is now accepted and ready to land.Dec 17 2019, 20:46