Page MenuHomePhabricator
Differential D4752

Fetch and check signature and sha256sum of debian ISO instead of comparing against a hardcoded hash
ClosedPublic
Actions

Authored by jasonbcox on Dec 17 2019, 19:43.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc3995cd40ef2: Fetch and check signature and sha256sum of debian ISO instead of comparing…
rABCc3995cd40ef2: Fetch and check signature and sha256sum of debian ISO instead of comparing…
Summary

See title. This is easier to maintain since version bumps only need to modify the first line.

Test Plan

Copy-paste these commands and run them.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
debian-verify
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8605
Build 15198: Default Diff Build & Tests
Build 15197: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 17 2019, 19:43
Herald added a reviewer: deadalnix. · View Herald TranscriptDec 17 2019, 19:43
Fabien requested changes to this revision.Dec 17 2019, 19:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/gitian-building/gitian-building-create-vm-debian.md
77

grep "debian-${DEBIAN_VERSION}-amd64-netinst.iso" SHA256SUMS | sha256sum -c

This revision now requires changes to proceed.Dec 17 2019, 19:57
jasonbcox updated this revision to Diff 14931.Dec 17 2019, 20:05

Fixed according to feedback + updated the instructions text above the commands.

teamcity added a comment.Dec 17 2019, 20:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 17 2019, 20:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 17 2019, 20:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8605: Diff 14930.Dec 17 2019, 20:43
Fabien accepted this revision.Dec 17 2019, 20:46
This revision is now accepted and ready to land.Dec 17 2019, 20:46
teamcity added a comment.Dec 17 2019, 20:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8606: Diff 14931.Dec 17 2019, 20:50
Closed by commit rABCc3995cd40ef2: Fetch and check signature and sha256sum of debian ISO instead of comparing… (authored by jasonbcox). · Explain WhyDec 17 2019, 21:55
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCc3995cd40ef2: Fetch and check signature and sha256sum of debian ISO instead of comparing….
jasonbcox added a commit: rSTAGINGc3995cd40ef2: Fetch and check signature and sha256sum of debian ISO instead of comparing….Apr 7 2020, 22:07

Revision Contents
Changeset List

PathSize
doc/
gitian-building/
13 lines

Diff 14930

View Options

doc/gitian-building/gitian-building-create-vm-debian.md

Loading...