Static assert with no message is a C++17 feature and warns on C++14
ClosedPublic
Actions

Authored by Fabien on Dec 18 2019, 07:41.

Details

Reviewers

deadalnix
nakihito
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGc6ab5bc3eb03: Static assert with no message is a C++17 feature and warns on C++14
rABCc6ab5bc3eb03: Static assert with no message is a C++17 feature and warns on C++14

Summary

Fix the -Wc++17-extensions warnings introduced in D4731.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 18 2019, 07:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2019, 07:41

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8616: Diff 14953.Dec 18 2019, 07:56

nakihito accepted this revision.Dec 18 2019, 08:10

This revision is now accepted and ready to land.Dec 18 2019, 08:10

markblundeberg accepted this revision.Dec 18 2019, 08:32

Closed by commit rABCc6ab5bc3eb03: Static assert with no message is a C++17 feature and warns on C++14 (authored by Fabien). · Explain WhyDec 18 2019, 08:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc6ab5bc3eb03: Static assert with no message is a C++17 feature and warns on C++14.

Fabien added a commit: rSTAGINGc6ab5bc3eb03: Static assert with no message is a C++17 feature and warns on C++14.Apr 7 2020, 22:08

Revision Contents
Changeset List

Path

Size

src/

compat/

assumptions.h

3 lines

Diff 14957

View Options

Static assert with no message is a C++17 feature and warns on C++14ClosedPublicActions