Paths

Table of Contentst

Differential D4754

[LINTER] Remove empty lines at the beginning of a block
ClosedPublic
Actions

Authored by Fabien on Dec 18 2019, 09:43.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING13008fb89c3e: [LINTER] Remove empty lines at the beginning of a block
rABC13008fb89c3e: [LINTER] Remove empty lines at the beginning of a block

Summary

Follow-up for https://reviews.bitcoinabc.org/D4678?id=14718#inline-29056

Documentation:
https://releases.llvm.org/8.0.0/tools/clang/docs/ClangFormatStyleOptions.html

Test Plan

Return no error:

arc lint --everything

Edit src/init.cpp and add an empty newline after any opening block.

arc lint -- src/init.cpp

Check the linter proposes to remove the newline.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 18 2019, 09:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2019, 09:43

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien mentioned this in D4678: add nSigChecks counting to EvalScript.Dec 18 2019, 09:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8620: Diff 14961.Dec 18 2019, 09:59

Thank you Captain Linter!

Now I want my god damn braces added automagically!

This revision is now accepted and ready to land.Dec 18 2019, 17:16

@deadalnix Nah, you didn't say "please" :)

Closed by commit rABC13008fb89c3e: [LINTER] Remove empty lines at the beginning of a block (authored by Fabien). · Explain WhyDec 18 2019, 20:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC13008fb89c3e: [LINTER] Remove empty lines at the beginning of a block.

Fabien added a commit: rSTAGING13008fb89c3e: [LINTER] Remove empty lines at the beginning of a block.Apr 7 2020, 22:09

Revision Contents
Changeset List

Path

Size

src/

1 line

1 line

1 line

1 line

rpc/

blockchain.cpp

1 line

rawtransaction.cpp

1 line

test/

1 line

1 line

1 line

3 lines

1 line

1 line

util/

system.cpp

1 line

wallet/

rpcdump.cpp

1 line

test/

wallet_crypto_tests.cpp

1 line

wallet.cpp

1 line

walletdb.cpp

1 line

Diff 14978

View Options

src/.clang-format

View Options

src/miner.cpp

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/hash_tests.cpp

View Options

src/test/netbase_tests.cpp

View Options

src/txdb.cpp

View Options

src/txmempool.cpp

View Options

src/util/system.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/test/wallet_crypto_tests.cpp

View Options

src/wallet/wallet.cpp

View Options

[LINTER] Remove empty lines at the beginning of a blockClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14978

src/.clang-format

src/miner.cpp

src/net.cpp

src/net_processing.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/test/coins_tests.cpp

src/test/crypto_tests.cpp

src/test/hash_tests.cpp

src/test/netbase_tests.cpp

src/txdb.cpp

src/txmempool.cpp

src/util/system.cpp

src/wallet/rpcdump.cpp

src/wallet/test/wallet_crypto_tests.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

[LINTER] Remove empty lines at the beginning of a block
ClosedPublic
Actions

Revision Contents
Changeset List