Page MenuHomePhabricator
Differential D4765

[CMAKE] Override default flags
ClosedPublic
Actions

Authored by Fabien on Dec 19 2019, 10:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa7812e1d3232: [CMAKE] Override default flags
rABCa7812e1d3232: [CMAKE] Override default flags
Summary

This is a bit of simplification for setting the default optimization
flags value. The OverrideInitFlags.cmake is loaded at the project()
call and is used to write the CMAKE_<LANG>_FLAGS_<CONFIGURATION> to
the cache.
This allow for removing the NDEBUG flag for release type
configurations, as well as overriding the default CFLAGS for the debug
configuration.

This is a first step toward refactoring the compilation flag assignment.
This does not change the current behavior.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 19 2019, 10:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2019, 10:49
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 19 2019, 10:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 19 2019, 11:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8637: Diff 14989.Dec 19 2019, 11:06
deadalnix accepted this revision.Dec 19 2019, 21:08
This revision is now accepted and ready to land.Dec 19 2019, 21:08
teamcity added a comment.Dec 19 2019, 21:27

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Dec 19 2019, 21:31

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Dec 19 2019, 21:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Dec 19 2019, 21:35

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Dec 19 2019, 21:40

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Dec 19 2019, 21:43

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABCa7812e1d3232: [CMAKE] Override default flags (authored by Fabien). · Explain WhyDec 20 2019, 08:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa7812e1d3232: [CMAKE] Override default flags.
Fabien added a commit: rSTAGINGa7812e1d3232: [CMAKE] Override default flags.Apr 7 2020, 22:10

Revision Contents
Changeset List

PathSize
5 lines
cmake/
modules/
15 lines
src/
15 lines

Diff 15018

View Options

CMakeLists.txt

Loading...
View Options

cmake/modules/OverrideInitFlags.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...