Merge #13824: doc: Remove outdated net comment
ClosedPublic
Actions

Authored by nakihito on Dec 19 2019, 22:28.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING2cc489588a64: Merge #13824: doc: Remove outdated net comment
rABC2cc489588a64: Merge #13824: doc: Remove outdated net comment

Summary

fa365021bbb4c0865e6655100c1cbf85e2b3c7fa doc: Remove outdated net comment (MarcoFalke)

Pull request description:

`mapAddresses` and the corresponding "critsect" has been removed in 5fee401fe14aa6459428a26a82f764db70a6a0b9 more than 6 years ago. Now is probably a good time to remove this confusing comment.

Tree-SHA512: 498a403d5703da395c18a7ebb776aa6e693e59fe43a839fefd261e0a5af58621763813979d4cfbd8d1728ce73b325b82002e393cde79bdbff33e0fbf68ab6747

Backport of Core PR13824
https://github.com/bitcoin/bitcoin/pull/13824/

Test Plan

make

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Dec 19 2019, 22:28

Owners added a reviewer: Restricted Owners Package.Dec 19 2019, 22:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2019, 22:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8648: Diff 15008.Dec 19 2019, 22:51

jasonbcox accepted this revision.Dec 20 2019, 00:44

This revision is now accepted and ready to land.Dec 20 2019, 00:44

Closed by commit rABC2cc489588a64: Merge #13824: doc: Remove outdated net comment (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyDec 20 2019, 19:21

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC2cc489588a64: Merge #13824: doc: Remove outdated net comment.

nakihito added a commit: rSTAGING2cc489588a64: Merge #13824: doc: Remove outdated net comment.Apr 7 2020, 22:12

Revision Contents
Changeset List

Path

Size

src/

net.cpp

4 lines

Diff 15046

View Options

Merge #13824: doc: Remove outdated net commentClosedPublicActions