Page MenuHomePhabricator
Differential D4783

[CMAKE] Make the functional test run with upgrade activated
ClosedPublic
Actions

Authored by Fabien on Dec 20 2019, 14:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2b5802d180b7: [CMAKE] Make the functional test run with upgrade activated
rABC2b5802d180b7: [CMAKE] Make the functional test run with upgrade activated
Summary

This adds a new target for running the functional tests with the phonon
activation time in the past. This target is also run by the magic target
check-upgrade-activated.

Depends on D4800.

Test Plan
ninja check-upgrade-activated

Check it runs the functional tests --with-phononactivation.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_functional_test_activated
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8686
Build 15358: Default Diff Build & Tests
Build 15357: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 20 2019, 14:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2019, 14:41
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 20 2019, 14:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4784: [CMAKE] Allow to run the extended functional tests.Dec 20 2019, 14:53
teamcity added a comment.Dec 20 2019, 15:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8660: Diff 15025.Dec 20 2019, 15:03
deadalnix requested changes to this revision.Dec 20 2019, 15:33

This is not a build configuration.

This revision now requires changes to proceed.Dec 20 2019, 15:33
Fabien planned changes to this revision.Dec 23 2019, 20:22
Fabien edited the summary of this revision. (Show Details)Dec 23 2019, 20:27
Fabien edited the test plan for this revision. (Show Details)
Fabien added a parent revision: D4800: [CMAKE] Add a check-upgrade-activated magic target.
Fabien removed a parent revision: D4782: Make the tests use phonon activation instead of graviton.
Fabien updated this revision to Diff 15080.Dec 23 2019, 20:28

Rebase on D4800.
Don't use a build configuration but adds a new target.

teamcity added a comment.Dec 23 2019, 20:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 23 2019, 20:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8686: Diff 15080.Dec 23 2019, 20:45
deadalnix accepted this revision.Jan 2 2020, 06:35
This revision is now accepted and ready to land.Jan 2 2020, 06:35
Closed by commit rABC2b5802d180b7: [CMAKE] Make the functional test run with upgrade activated (authored by Fabien). · Explain WhyJan 2 2020, 09:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2b5802d180b7: [CMAKE] Make the functional test run with upgrade activated.
Fabien added a commit: rSTAGING2b5802d180b7: [CMAKE] Make the functional test run with upgrade activated.Apr 7 2020, 22:14

Revision Contents
Changeset List

PathSize
test/
34 lines

Diff 15080

View Options

test/CMakeLists.txt

Loading...