Page MenuHomePhabricator

[CMAKE] Allow to run the extended functional tests
ClosedPublic

Authored by Fabien on Dec 20 2019, 14:53.

Details

Summary

This adds a couple targets to run the extended functional tests, with or
without the next upgrade activated.

Depends on D4783.

Test Plan
ninja check-functional-extended
ninja check-functional-extended-upgrade-activated

Check all the tests are run.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_function_tests_extended
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8661
Build 15308: Default Diff Build & Tests
Build 15307: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Dec 20 2019, 15:33

This is not the right approach. Why would someone would have to reconfigure the build to run extended tests?

What you need is a check-function-extended and check-extended targets.

This revision now requires changes to proceed.Dec 20 2019, 15:33
Fabien planned changes to this revision.Dec 23 2019, 20:29
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Don't require build time configuration.

This revision is now accepted and ready to land.Jan 2 2020, 06:35