Page MenuHomePhabricator

[CMAKE] Make check-upgrade-activated run the extended functional tests
AbandonedPublic

Authored by Fabien on Dec 23 2019, 20:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This diff updates the targets check-upgrade-activated to run the
extended test suite. The intent is to make it possible to run ALL
the tests with upgrade activated with a single target.

Test Plan
ninja check-upgrade-activated

Check all the functional tests are run.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_check_upgrade_run_extended
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8829
Build 15633: Bitcoin ABC Buildbot
Build 15632: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 23 2019, 20:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2019, 20:43

Oh great, I was going to ask about this.

(btw subsidy -> subset in description :D)

Fabien edited the summary of this revision. (Show Details)Dec 24 2019, 09:09

Ah yes, thanks it is fixed now !

deadalnix requested changes to this revision.Jan 2 2020, 06:36
deadalnix added inline comments.
test/CMakeLists.txt
73 ↗(On Diff #15082)

No.

Have check-extended do this.

This revision now requires changes to proceed.Jan 2 2020, 06:36
Fabien planned changes to this revision.Jan 10 2020, 12:41
Fabien retitled this revision from [CMAKE] Make check all run the extended functional test suite to [CMAKE] Make check-upgrade-activated run the extended functional tests.Jan 10 2020, 12:51
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien updated this revision to Diff 15292.Jan 10 2020, 13:20

Reduce the scope to upgrade activated tests only. check-extended will be added in another diff.

deadalnix requested changes to this revision.Jan 10 2020, 23:32

The elphant in the room is that the nomenclature for the upgrade activated things has different semantic than the non upgrade activated one, which is not right.

This revision now requires changes to proceed.Jan 10 2020, 23:32
Fabien abandoned this revision.Jan 11 2020, 06:05

Let's add a check-upgrade-activated-extended target then.